fix: hot swapping error in python ml function #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnguyen90
reviewed
Mar 31, 2025
There was a problem hiding this comment.
Can you make sure some of the other runtimes still work as expected? Particularly:
- node
- python
- dart
- bun
Also, it's possible to deploy a function where certain folders are symlinks. This helps to re-use code. For example, I have a symlink here to re-use this folder of common modules. Will this setup work locally with the CLI?
|
@stnguyen90 Yeah you are right, the approach i used would fail if any symlinks were used. I have changed it to just skip symlinks that are not valid and that throw an error. It will work the same for all the other files. |
|
And you've tested with multiple runtimes like:
|
@stnguyen90 yep i just did doing so. lgtm |
stnguyen90
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In python-ml function, we copy over files to
runtime-envhere - https://github.com/open-runtimes/open-runtimes/blob/088ef387b097cc7bb29aff6602372ac1196c5925/runtimes/python/versions/latest/helpers/prepare-start.sh#L4This folder contains various files, even including symlinks.
Symlinks when copied over won't be valid files anymore and hence the
getAllFilesfunction in CLI throws an error trying to fetch absolute paths for it.So the PR makes the function just skip any invalid symlinks.
Test Plan
Before:
After:
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes.