-
Notifications
You must be signed in to change notification settings - Fork 2
Add WASM build/test #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WASM build/test #576
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #576 +/- ##
=======================================
Coverage 98.11% 98.11%
=======================================
Files 119 119
Lines 32255 32265 +10
Branches 4288 4288
=======================================
+ Hits 31646 31656 +10
Misses 458 458
Partials 151 151 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@miklhh one likely reason for the failure is that we use dynamic linking flags somewhere. As you know these things much better than me, can you please have a look and suggest what to change? |
bfc12db to
8164311
Compare
|
I got this error when compiling on my Windows laptop (which I usually do not compile against, but trying to get to work): so I think we can say that Highway is the issue here. However, google/highway#2641 (comment) claims that CMake should use a static target by default. So why do we get a dynamic one here? (Or am I missing what this means?) |
|
I open a upstream fix for the WASM shared-library problem here |
|
I'll rebase this on top of main |
|
I'll also bump the cibuildwheel version to 3.1.4 and pin the Pyodide wheel version to 0.28.2. That way, the uploaded wheel artifact from this job can be directly tested in the interactive console on Pyodides website: https://pyodide.org/en/stable/console.html By the way, looking at the job logs, it seems that the APyTypes test suite is not running. |
b6f5657 to
b761058
Compare
52de7a4 to
2717946
Compare
cfea1ca to
fa432cc
Compare
MREfrom apytypes import *
assert APyFloat.from_float(APyFixed(3, bits=3, int_bits=-1), 7, 3).is_identical(APyFloat(0, 60, 4, 7, 3)) |
PR Summary
Closes #565
PR Checklist