Skip to content

Conversation

@oscargus
Copy link
Contributor

@oscargus oscargus commented Dec 7, 2024

PR Summary

Closes #565

PR Checklist

  • "closes #0000" is in the body of the PR description to link the related issue
  • [N/A] new and changed code is tested
  • [N/A] relevant changes added to CHANGELOG.md
  • [N/A] new functionality is documented

@codecov
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.11%. Comparing base (f8ce294) to head (b4177e1).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #576   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files         119      119           
  Lines       32255    32265   +10     
  Branches     4288     4288           
=======================================
+ Hits        31646    31656   +10     
  Misses        458      458           
  Partials      151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oscargus
Copy link
Contributor Author

oscargus commented Dec 7, 2024

@miklhh one likely reason for the failure is that we use dynamic linking flags somewhere. As you know these things much better than me, can you please have a look and suggest what to change?

@oscargus oscargus marked this pull request as draft February 17, 2025 22:18
@oscargus oscargus force-pushed the wasm branch 8 times, most recently from bfc12db to 8164311 Compare May 17, 2025 16:01
@oscargus oscargus changed the base branch from main to nb27 May 27, 2025 19:18
@oscargus oscargus changed the base branch from nb27 to main May 27, 2025 19:23
@oscargus oscargus closed this May 27, 2025
@oscargus oscargus reopened this May 27, 2025
@oscargus
Copy link
Contributor Author

I got this error when compiling on my Windows laptop (which I usually do not compile against, but trying to get to work):

  lld-link: error: /failifmismatch: mismatch detected for 'RuntimeLibrary':
  >>> _apytypes.cp312-win_amd64.pyd.p/subprojects_nanobind-2.8.0_src_nb_combined.cpp.obj has value MT_StaticRelease
  >>> subprojects/highway\libhwy.a.p/hwy_targets.cc.obj has value MD_DynamicRelease

so I think we can say that Highway is the issue here. However, google/highway#2641 (comment) claims that CMake should use a static target by default. So why do we get a dynamic one here? (Or am I missing what this means?)

@miklhh
Copy link
Member

miklhh commented Sep 5, 2025

I open a upstream fix for the WASM shared-library problem here

@miklhh
Copy link
Member

miklhh commented Sep 10, 2025

I'll rebase this on top of main

@miklhh
Copy link
Member

miklhh commented Sep 10, 2025

I'll also bump the cibuildwheel version to 3.1.4 and pin the Pyodide wheel version to 0.28.2. That way, the uploaded wheel artifact from this job can be directly tested in the interactive console on Pyodides website:

https://pyodide.org/en/stable/console.html

By the way, looking at the job logs, it seems that the APyTypes test suite is not running.

@miklhh miklhh force-pushed the wasm branch 4 times, most recently from b6f5657 to b761058 Compare September 10, 2025 10:38
@miklhh miklhh force-pushed the wasm branch 4 times, most recently from 52de7a4 to 2717946 Compare October 10, 2025 09:43
@miklhh miklhh force-pushed the wasm branch 17 times, most recently from cfea1ca to fa432cc Compare October 11, 2025 18:14
@miklhh
Copy link
Member

miklhh commented Oct 11, 2025

MRE

from apytypes import *

assert APyFloat.from_float(APyFixed(3, bits=3, int_bits=-1), 7, 3).is_identical(APyFloat(0, 60, 4, 7, 3)) 

@miklhh miklhh marked this pull request as ready for review October 11, 2025 20:51
@miklhh miklhh merged commit 91b666b into main Oct 15, 2025
87 checks passed
@miklhh miklhh deleted the wasm branch October 15, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WASM CI

3 participants