Introduces a separate thread in the UserManager. #21857
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johann-listunov
commented
Jul 15, 2025
|
|
||
| std::lock_guard guard{_loadFromDBLock}; // must be first | ||
| WRITE_LOCKER(writeGuard, _userCacheLock); // must be second | ||
| READ_LOCKER(readGuard, _userCacheLock); // must be second |
There was a problem hiding this comment.
Remove comment.
johann-listunov
commented
Jul 15, 2025
| @@ -379,27 +409,34 @@ VPackBuilder auth::UserManager::allUsers() { | |||
| } | |||
|
|
|||
| void auth::UserManager::triggerCacheRevalidation() { | |||
| triggerLocalReload(); | |||
| uint64_t versionToReloadTo = globalVersion() + 1; | |||
There was a problem hiding this comment.
Can be const.
johann-listunov
commented
Jul 15, 2025
| } | ||
| } | ||
| // This test is not really applicable anymore. | ||
| // Neither triggerGlobalReload or triggerLocal reload are incrementing the |
There was a problem hiding this comment.
Suggested change
| // Neither triggerGlobalReload or triggerLocal reload are incrementing the | |
| // Neither triggerGlobalReload or triggerLocalReload are incrementing the |
johann-listunov
commented
Jul 15, 2025
| @@ -229,7 +229,7 @@ function testSuite() { | |||
| } | |||
| let aliveStatus = waitForAlive(30, coordinator.url, { auth: { bearer: jwt } }); | |||
| // note: this should actually work, but currently doesn't TODO | |||
There was a problem hiding this comment.
Remove comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a separate thread to the UserManger to handle the load of the user-cache asynchronously.
This pre-loads the user-cache as fast as possible (as soon as the global version changes)
Also, compared to the old version, this allows the read-only operation to work on the user-cache
for longer and not block each other while trying to load a new version. On a high load environment this also
means a more responsive UserManger.
Scope & Purpose
Checklist
Related Information
(Please reference tickets / specification / other PRs etc)