Add EMST example #1214
Merged
Add EMST example #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
approved these changes
Feb 7, 2025
| // #2: (0, 1, 1.41) | ||
| // #3: (3, 4, 2.24) | ||
| // #4: (1, 2, 2.24) | ||
| printEdges(edges); |
There was a problem hiding this comment.
I would do printEdges(emst.edges);
There was a problem hiding this comment.
I did that at first. But decided to explicitly show a user how to get the edges in a separate line. Felt a bit more clear.
|
|
||
| template <typename MemorySpace> | ||
| void printEdges( | ||
| Kokkos::View<ArborX::Experimental::WeightedEdge *, MemorySpace> edges) |
There was a problem hiding this comment.
To be pedantic one would want to ensure that the view is contiguous here
There was a problem hiding this comment.
That would be more correct, yes. Don't think it's worthwhile, though.
examples/emst/example_emst.cpp
Outdated
| { | ||
| auto edges_host = | ||
| Kokkos::create_mirror_view_and_copy(Kokkos::HostSpace{}, edges); | ||
| std::sort(edges_host.data(), edges_host.data() + edges_host.size()); |
There was a problem hiding this comment.
Could sort it on the device with Kokkos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1189.