Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require C++20 #1215

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Require C++20 #1215

wants to merge 8 commits into from

Conversation

aprokop
Copy link
Contributor

@aprokop aprokop commented Feb 8, 2025

TODO:

  • Clang build
    Install LLVM 14 with gcc newer than 9 to get new libstdc++. Probably need to use newer image than ubuntu:18.04, but LLVM does not provide tarballs for any ubuntu other than 18.04.
    It is possible to install clang like this
    wget https://apt.llvm.org/llvm.sh
    chmod +x llvm.sh
    sudo ./llvm.sh 14
    
    But it does not give us full control over versioning.
  • Clang+CUDA build
    Need to figure it out. Clang 14 seems to support up to cuda 11.5, and there are weird compilation failures with 12, it seems.
    [CUDA 12] clang error: no template named 'texture' llvm/llvm-project#61340
    It was only fixed in Clang 16

@aprokop aprokop added build Build and installation testing Anything to do with tests and CI labels Feb 8, 2025
@aprokop aprokop force-pushed the c++20 branch 3 times, most recently from f54de5c to 732fabc Compare February 8, 2025 15:15
@masterleinad
Copy link
Collaborator

What's the motivation to require C++20 at this point?

@aprokop
Copy link
Contributor Author

aprokop commented Feb 10, 2025

What's the motivation to require C++20 at this point?

First of all, I don't yet know if we will. The arguments for it are:

  • Kokkos is going to switch in a few months
  • We are doing a backwards incompatible change with ArborX 2.0. If we do the switch to c++20 at the same time, we would only break backwards compatibility once

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build and installation testing Anything to do with tests and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants