-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require C++20 #1215
Draft
aprokop
wants to merge
8
commits into
arborx:master
Choose a base branch
from
aprokop:c++20
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Require C++20 #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uction llvm/llvm-project#54050 Implemented llvm/llvm-project@632dd6a 07/2023, first appeared in Clang 17
f54de5c
to
732fabc
Compare
What's the motivation to require C++20 at this point? |
First of all, I don't yet know if we will. The arguments for it are:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Clang
buildInstall LLVM 14 with gcc newer than 9 to get new libstdc++. Probably need to use newer image than
ubuntu:18.04
, but LLVM does not provide tarballs for any ubuntu other than 18.04.It is possible to install clang like this
Clang+CUDA
buildNeed to figure it out. Clang 14 seems to support up to cuda 11.5, and there are weird compilation failures with 12, it seems.
[CUDA 12] clang error: no template named 'texture' llvm/llvm-project#61340
It was only fixed in Clang 16