Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Kokkos swap and introduce KokkosExt header for StdAlgorithms #981

Closed
wants to merge 2 commits into from
Closed

Use Kokkos swap and introduce KokkosExt header for StdAlgorithms #981

wants to merge 2 commits into from

Conversation

aprokop
Copy link
Contributor

@aprokop aprokop commented Dec 14, 2023

No description provided.

@aprokop aprokop added the refactoring Code reorganization label Dec 14, 2023
dalg24
dalg24 requested changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not using Kokkos swap until it gets "promoted" to core

dalg24
dalg24 reviewed Dec 14, 2023
View reviewed changes
src/kokkos_ext/ArborX_DetailsKokkosExtStdAlgorithms.hpp

#include <Kokkos_Macros.hpp>
#include <Kokkos_StdAlgorithms.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not desirable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please elaborate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulling Kokkos.Core plus all of the Kokkos parallel algorithms to use a simple template function.

@aprokop
Copy link
Contributor Author

aprokop commented Dec 14, 2023 •
edited
Loading

Not using Kokkos swap until it gets "promoted" to core

Why not? I mean, I could maintain the "move to Kokkos std algorithms" branch on my own, but what's the downside here, especially compared to using other Kokkos::Experimental stuff in ArborX.

@aprokop aprokop closed this Dec 18, 2023
@aprokop aprokop deleted the use_kokkos_swap branch December 27, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 requested changes

Assignees
No one assigned
Labels
refactoring Code reorganization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aprokop @dalg24