Skip to content

fix: restore api keys tab and apply session key to pipeline default m… #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harz05 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: restore api keys tab and apply session key to pipeline default m… #504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions src/interfaces/chat_app/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3548,8 +3548,28 @@ def get_chat_response_stream(self):

# Get API key from session if available
session_api_key = None
if provider and 'provider_api_keys' in session:
session_api_key = session.get('provider_api_keys', {}).get(provider.lower())
session_provider_keys = session.get('provider_api_keys', {})
if provider and session_provider_keys:
session_api_key = session_provider_keys.get(provider.lower())
elif not provider and session_provider_keys:
# No explicit provider selected — check if the pipeline's active provider
# has a user-stored session key and inject it transparently so BYOK keys
# work even when the default pipeline model is being used (fixes #475).
try:
dyn = get_dynamic_config()
active_model = getattr(dyn, 'active_model', None) if dyn else None
if active_model and '/' in active_model:
pipeline_provider, pipeline_model = active_model.split('/', 1)
else:
chat_cfg = self.services_config.get('chat_app', {})
pipeline_provider = chat_cfg.get('default_provider')
pipeline_model = chat_cfg.get('default_model')
if pipeline_provider and pipeline_provider.lower() in session_provider_keys:
provider = pipeline_provider.lower()
model = model or pipeline_model
session_api_key = session_provider_keys[provider]
except Exception:
pass # Fall back to env key silently

def _event_stream() -> Iterator[str]:
padding = " " * 2048
Expand Down
10 changes: 5 additions & 5 deletions src/interfaces/chat_app/templates/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,12 +171,12 @@ <h3>Settings</h3>
</svg>
<span>Models</span>
</button>
<!-- <button class="settings-nav-item" data-section="api-keys" aria-selected="false">
<button class="settings-nav-item" data-section="api-keys" aria-selected="false">
<svg width="18" height="18" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2">
<path d="M21 2l-2 2m-7.61 7.61a5.5 5.5 0 1 1-7.778 7.778 5.5 5.5 0 0 1 7.777-7.777zm0 0L15.5 7.5m0 0l3 3L22 7l-3-3m-3.5 3.5L19 4"></path>
</svg>
<span>API Keys</span>
</button> -->
</button>
<!-- <button class="settings-nav-item" data-section="advanced" aria-selected="false">
<svg width="18" height="18" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2">
<circle cx="12" cy="12" r="3"></circle>
Expand Down Expand Up @@ -234,16 +234,16 @@ <h4 class="settings-section-title" id="models-heading">Model Provider</h4>
</section>

<!-- API Keys Section -->
<!-- <section class="settings-section" id="settings-api-keys" aria-labelledby="api-keys-heading" hidden>
<section class="settings-section" id="settings-api-keys" aria-labelledby="api-keys-heading" hidden>
<h4 class="settings-section-title" id="api-keys-heading">API Keys</h4>
<p class="settings-description">Configure API keys for providers. Keys are stored securely in your browser session and are never logged or sent to our servers.</p>
<p class="settings-description">Override the deployment API key with your own. Keys are stored in your browser session only and cleared when you close the tab.</p>

<div class="settings-group">
<div id="api-keys-container" class="api-keys-container">
<div class="api-key-loading">Loading...</div>
</div>
</div>
</section> -->
</section>

<!-- Advanced Section -->
<!-- <section class="settings-section" id="settings-advanced" aria-labelledby="advanced-heading" hidden>
Expand Down