feat(#4466): support optdepends of linux-firmware - #4712
Open
h8d13 wants to merge 5 commits into
Open
Conversation
Signed-off-by: h8d13 <hadean-eon-dev@proton.me>
Signed-off-by: h8d13 <hadean-eon-dev@proton.me>
Signed-off-by: h8d13 <hadean-eon-dev@proton.me>
Signed-off-by: h8d13 <hadean-eon-dev@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to discussion #4466
Instead of adding PCIDs detection or touching any existing logic; simply expose the optional set for user to select. Goal was to reduce maintain burden as this simply needs to track new
optdependsThis is then strapped at
_base_packagesas an.extend()before themkinitcpio -Pcall.Since it's fully optional, to me it should not be gated behind
--advanced, we initialize as empty[]and extend selections.This would notably make some Marvell Wifi card users happy (i,e surface type devices) and QCOM being quite common nowadays. The others, I've had little experience with.