Skip to content

Conversation

@pm0kjp
Copy link
Contributor

@pm0kjp pm0kjp commented Dec 18, 2024

Old (broken) cartoon in last box: https://liascript.github.io/course/?https://raw.githubusercontent.com/arcus/education_modules/main/demystifying_large_language_models/demystifying_large_language_models.md#8
New (fixed with help from Andre): https://liascript.github.io/course/?https://raw.githubusercontent.com/arcus/education_modules/fix-cartoon/demystifying_large_language_models/demystifying_large_language_models.md#8

The new parser breaks nested markdown, Andre provided this fix, we might need to copy this approach elsewhere. He writes:

One " was not closed, I added one after DeepAIHire ... I will have to fix this, the parser seems to be too greedy in this case, actually it should stop at the closing bracket ]. The quotes are translated into Unicode symbols, based on the language definition. You will see the difference better, if you change the language to de (German), we start at the bottom, or fr who use << >> ... but this should not affect the link detection ...
Parsing titles in images is a simple rule, that searches for the closing brackets and parentheses " ... ) only. In this case nested links, will be identified as the end. I changed this to html-links ... but I will also try to make this more robust

@pm0kjp pm0kjp requested a review from rosemm December 18, 2024 15:59
Copy link
Contributor

@leemc-data-ed leemc-data-ed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@leemc-data-ed leemc-data-ed merged commit b02d167 into main Dec 18, 2024
2 checks passed
@leemc-data-ed leemc-data-ed deleted the fix-cartoon branch December 18, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants