feat: add null-safe TryFromValue signature and tests#577
Open
teesofttech wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the SmartEnum<TEnum, TValue>.TryFromValue API to be null-safe and adds unit tests covering TryFromValue behavior for both int-backed and string-backed smart enums.
Changes:
- Update
TryFromValueto accept nullable input (TValue?) and avoid exceptions on null input. - Add new unit tests validating
TryFromValuesuccess/failure cases for value and string enums.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/SmartEnum/SmartEnum.cs |
Adjusts TryFromValue signature/implementation to handle nullable inputs. |
test/SmartEnum.UnitTests/SmartEnumTryFromValue.cs |
Adds tests exercising TryFromValue behavior for matching/non-matching values and null string input. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
@ardalis Can you review this PR please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add null-safe TryFromValue signature and tests