Closed
Conversation
specify functions rather than strings, with the gateway fieldNode as a parameter, returning the required selection set for the target schema, allows passing arguments from the gateway to the target schema.
Collaborator
Author
Collaborator
Author
|
;) abandoning for now. Fix will require a lot of ugly code that is not in my opinion worth it, as the only breaking change in #1650 is for users of undocumented getErrors function as well as for the otherwise internal only errors annotation. Might be worth releasing as patch version as I am not clear if we are following semver for undocumented functions, or in next major version, but is not worth releasing twice, once in an ugly version and then once in clean, at least in my opinion in terms of my unpaid time. Alas! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in preparation for fixing #1047