-
-
Notifications
You must be signed in to change notification settings - Fork 828
createRequest
with transforms API
#724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
f9c46be
createBatchOperation with transforms API
33dcd04
Merge branch 'next-api' of git://github.com/apollographql/graphql-too…
db3a233
Fix tests for adjacent fields in fragments
b3a97c6
remove createDocument that is no longer used or exported
34d4eb5
WIP fix createOperation API (thanks freiksenet)
5552a3e
WIP: address more review comments
02db0a4
Remove hack that will cause bugs
251d0dc
Fix tests
8c5e3c8
Clean up
a726453
Fix bugs related to passing no arguments
a98d8cc
Add two tests (let me know if i should move them)
6b28177
Return `Request` type, createOperation -> createDocument
242cde0
More tests for createDocument
a8704ac
Merge branch 'next-api' of git://github.com/apollographql/graphql-too…
fade3fb
Add execution test
4be53ed
createDocuments docs
5bb040b
createDocument -> createRequest
6592810
Export createRequest
11697ae
Merge branch 'next-api' of https://github.com/apollographql/graphql-t…
e657fae
Merge branch 'master' into apollographql-next-api
ce7a18d
Merge branch 'master' into apollographql-next-api
eeb1a84
Merge branch 'master' into apollographql-next-api
bbc0265
Merge branch 'master' into apollographql-next-api
30b9119
Merge branch 'master' into apollographql-next-api
188442d
Merge branch 'master' into apollographql-next-api
88407e4
Merge branch 'master' into apollographql-next-api
1b8cafd
Merge branch 'master' into apollographql-next-api
8fd2a46
Address review comments
9e92ba6
Reword docs (typo)
5f46b3e
Merge branch 'master' into apollographql-next-api
779100b
Merge branch 'master' into apollographql-next-api
fed0f01
Merge branch 'master' into apollographql-next-api
948355e
Merge branch 'master' into apollographql-next-api
a61afae
Merge branch 'master' into apollographql-next-api
mfix22 ffd5f4c
Merge branch 'master' into apollographql-next-api
a8e5038
Merge branch 'master' into apollographql-next-api
2a8e82c
Merge branch 'master' into apollographql-next-api
hwillson 536805b
Merge branch 'master' into apollographql-next-api
mfix22 e08cc10
Merge branch 'master' into apollographql-next-api
mfix22 5607de4
Merge branch 'master' into apollographql-next-api
mfix22 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General question: why not just construct a query that uses alias syntax?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean that is what this is doing, just programmatically right? This lets users define a batch operation (with many roots) and send that via a
fetch
etc.If you just form the query from a string, you are missing all the other operations that the transforms do.