Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Nov 27, 2025

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Nov 27, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 27, 2025

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes

    • Fixed Node 24 and Express compatibility issues.
  • Improvements

    • Enhanced streaming performance and reliability.
  • Chores

    • Updated development dependencies including build tools and testing frameworks.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

Multiple dependency version bumps across e2e and root packages. Adds string body handling in node-fetch fetchNodeHttp. Refactors streaming abstractions in server utils with new pumpToWritable utility. Fixes Node 24 + Express compatibility by replacing Proxy-based request property access with Reflect.get to preserve correct this-context.

Changes

Cohort / File(s) Summary
Changesets
.changeset/mighty-cars-mate.md, .changeset/real-forks-deny.md, .changeset/wise-impalas-grow.md
Three new changeset files declared: @whatwg-node/node-fetch patch for string body writing; @whatwg-node/server patches for Node 24 + Express compatibility and streaming improvements
E2E dependency updates
e2e/aws-lambda/package.json, e2e/azure-function/package.json, e2e/vercel/package.json
esbuild bumped from 0.27.0 to 0.27.1 in devDependencies
E2E Cloudflare packages
e2e/cloudflare-modules/package.json, e2e/cloudflare-workers/package.json
wrangler bumped from 4.51.0 to 4.52.1 in devDependencies
Root package.json devDependencies: @eslint/eslintrc 3.3.1→3.3.3, prettier 3.6.2→3.7.4, ts-jest 29.4.5→29.4.6, vitest 4.0.14→4.0.15; overrides: esbuild 0.27.0→0.27.1, vite 7.2.4→7.2.6
Server package dependencies
packages/server/package.json
@types/express 5.0.5→5.0.6 and express 5.2.0→5.2.1 in devDependencies
Node-fetch body handling
packages/node-fetch/src/fetchNodeHttp.ts
Added new branch to handle String bodyType: writes string directly to node request via safeWrite and ends stream on completion or rejection
Node-fetch utilities
packages/node-fetch/src/utils.ts
Generalized endStream signature to accept variadic arguments; refactored safeWrite with generic TWritable type parameter to infer chunk type from stream's write method signature
Node-fetch tests
packages/node-fetch/tests/reproductions.spec.ts
Replaced three runtime console.log statements with equivalent inline comments in streaming test callbacks
Server adapter formatting
packages/server/src/createServerAdapter.ts, packages/server/src/types.ts
Reformatted generic parameter constraints from multi-line to inline format; no functional changes to type semantics or defaults
Server utilities refactor
packages/server/src/utils.ts
Major refactor: rewrote normalizeNodeRequest to use Reflect.get on actual request object (fixes Node 24 + Express compatibility); introduced new pumpToWritable abstraction and supporting types; refactored sendAsyncIterable and sendReadableStream to use centralized pump logic; added helper utilities endDest and generic safeWrite
Server test suite
packages/server/test/reproductions.spec.ts
Added new test case "express + body_parser + url property in the plugin" verifying request URL access and JSON body handling with Express adapter using handleMaybePromise

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • packages/server/src/utils.ts: Substantial streaming refactor with new pumpToWritable abstraction and Reflect.get-based request property access (Node 24 fix)—requires careful review of streaming logic and this-context preservation
  • packages/node-fetch/src/fetchNodeHttp.ts: String body handling logic and integration with updated safeWrite signature
  • packages/server/test/reproductions.spec.ts: New test case validates the Node 24 + Express compatibility fix and URL property access
  • packages/node-fetch/src/utils.ts: Type signature changes for endStream and safeWrite—verify backward compatibility and type correctness

Possibly related PRs

Suggested reviewers

  • enisdenjo
  • EmrysMyrddin
  • dotansimha

Poem

🐰 A stream of bytes flows swift and true,
No private #state shall block our view!
With Reflect.get, Express now sings,
And Node 24 spreads its wings.
Pumpity-pump through every layer—
A rabbit's fix beyond compare! 🌙✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main changes: dependency bumps, improvements, and compatibility fixes for Node 24 with Express and Next.js, which aligns with the changeset contents.
Description check ✅ Passed The description mentions bumping dependencies and references issue #2971, which directly relates to the changeset that includes dependency updates and fixes for Node 24 + Express compatibility.
Linked Issues check ✅ Passed The PR addresses issue #2971 by fixing the TypeError from accessing private members via Reflect.get. Changes in packages/server/src/utils.ts introduce a Reflect.get wrapper in normalizeNodeRequest to preserve this-context, directly resolving the reported compatibility issue.
Out of Scope Changes check ✅ Passed All changes are in scope: dependency version bumps, Node 24 + Express compatibility fixes, streaming improvements, type signature refinements, and a test for the fix. No unrelated modifications detected.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch renovate/all-minor-patch

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2dcbaec and 1066670.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (17)
  • .changeset/mighty-cars-mate.md (1 hunks)
  • .changeset/real-forks-deny.md (1 hunks)
  • .changeset/wise-impalas-grow.md (1 hunks)
  • e2e/aws-lambda/package.json (1 hunks)
  • e2e/azure-function/package.json (1 hunks)
  • e2e/cloudflare-modules/package.json (1 hunks)
  • e2e/cloudflare-workers/package.json (1 hunks)
  • e2e/vercel/package.json (1 hunks)
  • package.json (2 hunks)
  • packages/node-fetch/src/fetchNodeHttp.ts (1 hunks)
  • packages/node-fetch/src/utils.ts (1 hunks)
  • packages/node-fetch/tests/reproductions.spec.ts (2 hunks)
  • packages/server/package.json (1 hunks)
  • packages/server/src/createServerAdapter.ts (2 hunks)
  • packages/server/src/types.ts (1 hunks)
  • packages/server/src/utils.ts (5 hunks)
  • packages/server/test/reproductions.spec.ts (2 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: ardatan
Repo: ardatan/whatwg-node PR: 0
File: :0-0
Timestamp: 2025-01-29T19:45:36.028Z
Learning: The node-fetch package tries different fetch implementations in the following order: 1) node-libcurl 2) undici 3) built-in undici in Node 4) node:http as fallback
📚 Learning: 2025-01-29T19:45:47.290Z
Learnt from: ardatan
Repo: ardatan/whatwg-node PR: 0
File: :0-0
Timestamp: 2025-01-29T19:45:47.290Z
Learning: The `handleNodeRequestAndResponse` method in `whatwg-node/server` can be used to integrate with Fastify by passing both the request and reply objects in the route handler, along with the context containing `req` and `reply`.

Applied to files:

  • packages/server/test/reproductions.spec.ts
  • packages/server/src/utils.ts
  • packages/node-fetch/src/fetchNodeHttp.ts
  • .changeset/real-forks-deny.md
  • packages/server/src/types.ts
🧬 Code graph analysis (3)
packages/server/test/reproductions.spec.ts (4)
packages/server/test/test-server.ts (3)
  • url (333-335)
  • url (443-445)
  • fetch (48-50)
packages/node-fetch/src/Request.ts (1)
  • url (118-127)
packages/server/src/createServerAdapter.ts (1)
  • createServerAdapter (554-554)
packages/promise-helpers/src/index.ts (1)
  • handleMaybePromise (29-42)
packages/server/src/utils.ts (2)
packages/node-fetch/src/utils.ts (2)
  • fakePromise (36-36)
  • safeWrite (117-125)
packages/promise-helpers/src/index.ts (4)
  • fakePromise (47-94)
  • MaybePromise (1-1)
  • handleMaybePromise (29-42)
  • resolve (114-116)
packages/node-fetch/src/fetchNodeHttp.ts (2)
packages/promise-helpers/src/index.ts (2)
  • handleMaybePromise (29-42)
  • reject (117-119)
packages/node-fetch/src/utils.ts (2)
  • safeWrite (117-125)
  • endStream (112-115)
🔇 Additional comments (25)
e2e/cloudflare-workers/package.json (1)

19-19: LGTM — patch version bump to wrangler.

Patch-level dependency update to build tooling; no functional impact.

e2e/azure-function/package.json (1)

20-20: LGTM — coordinated patch version bump to esbuild.

Patch-level dependency update; aligned with same version bump in other e2e packages and root overrides.

.changeset/wise-impalas-grow.md (1)

1-5: LGTM — changeset correctly declares streaming improvements.

Patch-level changeset properly formatted and aligned with streaming refactor scope.

e2e/vercel/package.json (1)

24-24: LGTM — patch version bump to esbuild in Vercel e2e environment.

Patch-level dependency update. This environment is critical for validating Node 24 + Express compatibility; actual fix implementation should be verified in server code.

.changeset/real-forks-deny.md (1)

1-5: LGTM — changeset correctly declares Node 24 + Express compatibility fix.

Patch-level changeset properly formatted. The description aligns with PR objectives to fix issue #2971 (TypeError from accessing private #state member in undici/Express context).

.changeset/mighty-cars-mate.md (1)

1-5: LGTM — changeset correctly declares string body handling improvement.

Patch-level changeset properly formatted. The description aligns with improvements to node-fetch request body handling when bodyType is "String".

e2e/aws-lambda/package.json (1)

20-20: LGTM — coordinated patch version bump to esbuild.

Patch-level dependency update; aligned with same version bump across other e2e packages (azure-function, vercel) and root overrides.

packages/server/package.json (1)

46-46: Express 5.2.1 and @types/express 5.0.6 patches are safe to merge.

Express 5.2.1 only reverts an erroneous breaking change from v5.2.0 and does not introduce Node 24-specific breaking changes. Both updates are patch-level and pose no risk to the server adapter. The Node 24 + Express compatibility fix using Reflect.get is already properly implemented in createServerAdapter.ts (lines 198–201 and 499–512).

e2e/cloudflare-modules/package.json (1)

19-19: LGTM!

The wrangler version bump is part of the routine dependency updates for this PR.

packages/node-fetch/src/fetchNodeHttp.ts (1)

162-167: LGTM!

The new String body handling path follows the same pattern as the existing _buffer handling and correctly uses the promise-based utilities for writing and ending the stream.

packages/server/src/types.ts (1)

14-15: LGTM!

The inline formatting of the generic constraint is a style improvement with no functional impact.

packages/server/test/reproductions.spec.ts (2)

7-7: LGTM!

The import is properly added to support the new test case below.


141-181: LGTM!

The new test provides good coverage for the Express integration with plugins and the handleMaybePromise utility. The test structure is consistent with existing tests and validates both the response body and the URL captured by the plugin.

packages/node-fetch/tests/reproductions.spec.ts (1)

21-21: LGTM!

Good cleanup removing debug console.log statements while preserving the context through comments.

Also applies to: 25-25, 37-37, 39-39

packages/node-fetch/src/utils.ts (2)

112-115: LGTM!

The updated endStream signature is more flexible while maintaining the same behavior. The implementation correctly avoids the arguments adaptor trampoline by passing explicit null values.


117-125: LGTM!

The generic typing improves type safety by inferring the correct chunk type from the writable stream's write method signature.

packages/server/src/utils.ts (6)

4-4: LGTM!

The Writable import is properly added to support the new streaming utilities.


171-189: Critical fix for Node 24 compatibility - LGTM!

This change resolves the "TypeError: Cannot read private member #state" error mentioned in issue #2971. By using Reflect.get(request, prop, request) instead of direct property access through the receiver, the code ensures that private members are accessed on the actual request object instance. The function wrapper preserves the correct this context while preventing private member access violations.


254-259: LGTM!

The refactor to use pumpToWritable reduces code duplication and centralizes the streaming logic while maintaining the same behavior.


261-299: LGTM!

The new streaming utilities provide clean, reusable abstractions for pumping async iterables to writable streams with proper backpressure handling. The generic typing ensures type safety across different stream types.


365-373: LGTM!

The String body handling follows the same pattern as buffer handling and properly uses the safeWrite utility for backpressure management.


433-433: LGTM!

The refactor simplifies the implementation by delegating to the pumpToWritable utility while maintaining the same streaming behavior.

package.json (1)

45-45: All dependency versions are valid and have no known security vulnerabilities. Verification confirmed:

packages/server/src/createServerAdapter.ts (2)

79-80: Type parameter formatting improvements.

Inlining the generic constraints improves readability without affecting behavior or type resolution. ✓

Also applies to: 94-97


509-516: Verify Node 24 compatibility fix completeness.

Line 511-512 correctly uses Reflect.get(adapterObj, prop, adapterObj) to preserve this-context for Symbol properties and Deno, addressing the private member access issue. However, the remaining property access paths (lines 517–545) continue using direct bracket notation and manual bind patterns.

Clarify whether the private member error only manifests for Symbol properties, or whether other property access paths (particularly at lines 517, 524, 532) also require Reflect.get for full Node 24 compatibility.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

@benchmarks/node-fetch results (noConsumeBody)

   ✓ active_handles.................: avg=138.836449 min=47       med=139     max=190      p(90)=162     p(95)=168    
     data_received..................: 37 MB  1.2 MB/s
     data_sent......................: 24 MB  788 kB/s
     http_req_blocked...............: avg=2.64µs     min=477ns    med=1.13µs  max=10.7ms   p(90)=1.87µs  p(95)=2.35µs 
     http_req_connecting............: avg=902ns      min=0s       med=0s      max=4.38ms   p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=12.5ms     min=699.71µs med=12.09ms max=563.27ms p(90)=16.62ms p(95)=18.63ms
       { expected_response:true }...: avg=12.5ms     min=699.71µs med=12.09ms max=563.27ms p(90)=16.62ms p(95)=18.63ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 238795
     http_req_receiving.............: avg=29.37µs    min=6.6µs    med=17.85µs max=26.45ms  p(90)=31.52µs p(95)=38.34µs
     http_req_sending...............: avg=10.59µs    min=2.51µs   med=6.34µs  max=17.03ms  p(90)=9.85µs  p(95)=13.05µs
     http_req_tls_handshaking.......: avg=0s         min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=12.46ms    min=515.21µs med=12.05ms max=563.23ms p(90)=16.58ms p(95)=18.55ms
     http_reqs......................: 238795 7958.704663/s
     iteration_duration.............: avg=25.11ms    min=3.96ms   med=23.95ms max=577.72ms p(90)=29.2ms  p(95)=32.15ms
     iterations.....................: 119382 3978.835738/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

@benchmarks/server results (undici)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 178222      ✗ 0    
     data_received..................: 18 MB   591 kB/s
     data_sent......................: 13 MB   443 kB/s
     http_req_blocked...............: avg=1.7µs    min=992ns    med=1.59µs   max=174.05µs p(90)=2.07µs   p(95)=2.35µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=123.8µs  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=260.39µs min=196.06µs med=245.87µs max=81.42ms  p(90)=279.64µs p(95)=294.89µs
       { expected_response:true }...: avg=260.39µs min=196.06µs med=245.87µs max=81.42ms  p(90)=279.64µs p(95)=294.89µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 89111
     http_req_receiving.............: avg=28.89µs  min=15.02µs  med=27.66µs  max=2.68ms   p(90)=34.93µs  p(95)=36.74µs 
     http_req_sending...............: avg=9.63µs   min=5.73µs   med=9.43µs   max=378.9µs  p(90)=13.07µs  p(95)=14.42µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=221.86µs min=165.69µs med=207.61µs max=81.33ms  p(90)=240.01µs p(95)=254.27µs
     http_reqs......................: 89111   2970.270152/s
     iteration_duration.............: avg=331.81µs min=261.88µs med=316.39µs max=81.57ms  p(90)=354.05µs p(95)=372.76µs
     iterations.....................: 89111   2970.270152/s
     vus............................: 1       min=1         max=1  
     vus_max........................: 1       min=1         max=1  

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

@benchmarks/node-fetch results (consumeBody)

   ✓ active_handles.................: avg=139.6598 min=67     med=139     max=191      p(90)=161     p(95)=167    
     data_received..................: 24 MB  786 kB/s
     data_sent......................: 15 MB  504 kB/s
     http_req_blocked...............: avg=4.47µs   min=641ns  med=1.53µs  max=14.73ms  p(90)=2.13µs  p(95)=2.51µs 
     http_req_connecting............: avg=2.41µs   min=0s     med=0s      max=7.31ms   p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=19.38ms  min=1.78ms med=18.92ms max=678.07ms p(90)=24.99ms p(95)=27.26ms
       { expected_response:true }...: avg=19.38ms  min=1.78ms med=18.92ms max=678.07ms p(90)=24.99ms p(95)=27.26ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 154213
     http_req_receiving.............: avg=37.43µs  min=8.93µs med=25.98µs max=24.08ms  p(90)=40.77µs p(95)=49.07µs
     http_req_sending...............: avg=12.46µs  min=3.22µs med=7.68µs  max=23.09ms  p(90)=10.82µs p(95)=16.07µs
     http_req_tls_handshaking.......: avg=0s       min=0s     med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=19.33ms  min=1.45ms med=18.88ms max=677.92ms p(90)=24.94ms p(95)=27.19ms
     http_reqs......................: 154213 5139.988364/s
     iteration_duration.............: avg=38.88ms  min=8.5ms  med=37.56ms max=698.92ms p(90)=43.38ms p(95)=48.01ms
     iterations.....................: 77087  2569.344238/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

@benchmarks/server results (ponyfill)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 292242      ✗ 0     
     data_received..................: 29 MB   960 kB/s
     data_sent......................: 22 MB   726 kB/s
     http_req_blocked...............: avg=1.3µs    min=678ns    med=1.17µs   max=280.92µs p(90)=1.63µs   p(95)=1.93µs  
     http_req_connecting............: avg=0ns      min=0s       med=0s       max=110.27µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=137.24µs min=77.34µs  med=132.33µs max=5.91ms   p(90)=157.98µs p(95)=166.09µs
       { expected_response:true }...: avg=137.24µs min=77.34µs  med=132.33µs max=5.91ms   p(90)=157.98µs p(95)=166.09µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 146121
     http_req_receiving.............: avg=22µs     min=8.41µs   med=20.48µs  max=2.8ms    p(90)=29.33µs  p(95)=32.4µs  
     http_req_sending...............: avg=7.12µs   min=3.7µs    med=6.45µs   max=322.98µs p(90)=9.9µs    p(95)=11.85µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=108.11µs min=58.98µs  med=103.24µs max=5.61ms   p(90)=125.78µs p(95)=132.78µs
     http_reqs......................: 146121  4870.531408/s
     iteration_duration.............: avg=201.11µs min=121.76µs med=196.32µs max=6.37ms   p(90)=226µs    p(95)=236.34µs
     iterations.....................: 146121  4870.531408/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

@benchmarks/server results (uws)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 248436      ✗ 0     
     data_received..................: 21 MB   692 kB/s
     data_sent......................: 19 MB   617 kB/s
     http_req_blocked...............: avg=1.53µs   min=882ns    med=1.47µs   max=167.94µs p(90)=1.94µs   p(95)=2.12µs  
     http_req_connecting............: avg=0ns      min=0s       med=0s       max=119.74µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=167.73µs min=114.5µs  med=159.22µs max=16.02ms  p(90)=180.11µs p(95)=187.62µs
       { expected_response:true }...: avg=167.73µs min=114.5µs  med=159.22µs max=16.02ms  p(90)=180.11µs p(95)=187.62µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 124218
     http_req_receiving.............: avg=23.46µs  min=11.39µs  med=22.19µs  max=2.71ms   p(90)=27.86µs  p(95)=30.53µs 
     http_req_sending...............: avg=9.04µs   min=5.54µs   med=9.24µs   max=465.35µs p(90)=11.15µs  p(95)=12.84µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=135.21µs min=89.23µs  med=127.38µs max=15.95ms  p(90)=145.87µs p(95)=152.8µs 
     http_reqs......................: 124218  4140.447645/s
     iteration_duration.............: avg=237.07µs min=169.06µs med=227.44µs max=16.16ms  p(90)=252.48µs p(95)=262.16µs
     iterations.....................: 124218  4140.447645/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

@benchmarks/server results (native)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 197568      ✗ 0    
     data_received..................: 20 MB   655 kB/s
     data_sent......................: 15 MB   491 kB/s
     http_req_blocked...............: avg=1.6µs    min=972ns    med=1.58µs   max=205.12µs p(90)=1.97µs   p(95)=2.14µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=133.33µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=230.59µs min=168.27µs med=219.77µs max=16.78ms  p(90)=249.94µs p(95)=263.62µs
       { expected_response:true }...: avg=230.59µs min=168.27µs med=219.77µs max=16.78ms  p(90)=249.94µs p(95)=263.62µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 98784
     http_req_receiving.............: avg=25.92µs  min=14.1µs   med=24.37µs  max=2.62ms   p(90)=29.97µs  p(95)=33.09µs 
     http_req_sending...............: avg=9.31µs   min=5.66µs   med=9.44µs   max=297.43µs p(90)=11.14µs  p(95)=12.73µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=195.35µs min=143.28µs med=185.71µs max=16.71ms  p(90)=213.59µs p(95)=226.35µs
     http_reqs......................: 98784   3292.548063/s
     iteration_duration.............: avg=299.26µs min=225.74µs med=287.26µs max=16.94ms  p(90)=320.67µs p(95)=337.3µs 
     iterations.....................: 98784   3292.548063/s
     vus............................: 1       min=1         max=1  
     vus_max........................: 1       min=1         max=1  

@renovate renovate bot force-pushed the renovate/all-minor-patch branch from 2613781 to 3dacae4 Compare November 28, 2025 17:35
@renovate renovate bot changed the title chore(deps): update dependency prettier to v3.7.1 chore(deps): update all non-major dependencies Nov 28, 2025
@renovate renovate bot force-pushed the renovate/all-minor-patch branch 10 times, most recently from 033321c to e750327 Compare December 3, 2025 20:50
@renovate renovate bot force-pushed the renovate/all-minor-patch branch from e750327 to 67bcac7 Compare December 4, 2025 06:43
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@whatwg-node/node-fetch 0.8.5-alpha-20251204164651-10666707bffc27d1e49d3c44cde95d3bcbb9baa2 npm ↗︎ unpkg ↗︎
@whatwg-node/server 0.10.18-alpha-20251204164651-10666707bffc27d1e49d3c44cde95d3bcbb9baa2 npm ↗︎ unpkg ↗︎

@ardatan ardatan changed the title chore(deps): update all non-major dependencies Bump dependencies, improvements and fix compatibility issues with Node 24 + Express & Next.js Dec 4, 2025
@ardatan ardatan requested a review from enisdenjo December 4, 2025 16:50
@ardatan
Copy link
Owner

ardatan commented Dec 4, 2025

@copilot review
@coderabbitai review
@gemini-code-assist review

Copy link

Copilot AI commented Dec 4, 2025

@ardatan I've opened a new pull request, #2977, to work on those changes. Once the pull request is ready, I'll request review from you.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 4, 2025

@ardatan: I'll review the changes in this PR now.

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@renovate
Copy link
Contributor Author

renovate bot commented Dec 4, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read private member #state from an object whose class did not declare it

2 participants