-
-
Notifications
You must be signed in to change notification settings - Fork 36
Bump dependencies, improvements and fix compatibility issues with Node 24 + Express & Next.js #2963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughMultiple dependency version bumps across e2e and root packages. Adds string body handling in node-fetch fetchNodeHttp. Refactors streaming abstractions in server utils with new pumpToWritable utility. Fixes Node 24 + Express compatibility by replacing Proxy-based request property access with Reflect.get to preserve correct this-context. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (17)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2025-01-29T19:45:47.290ZApplied to files:
🧬 Code graph analysis (3)packages/server/test/reproductions.spec.ts (4)
packages/server/src/utils.ts (2)
packages/node-fetch/src/fetchNodeHttp.ts (2)
🔇 Additional comments (25)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅
|
✅
|
✅
|
✅
|
✅
|
✅
|
2613781 to
3dacae4
Compare
033321c to
e750327
Compare
e750327 to
67bcac7
Compare
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@whatwg-node/node-fetch |
0.8.5-alpha-20251204164651-10666707bffc27d1e49d3c44cde95d3bcbb9baa2 |
npm ↗︎ unpkg ↗︎ |
@whatwg-node/server |
0.10.18-alpha-20251204164651-10666707bffc27d1e49d3c44cde95d3bcbb9baa2 |
npm ↗︎ unpkg ↗︎ |
|
@copilot review |
|
@ardatan: I'll review the changes in this PR now. ✅ Actions performedReview triggered.
|
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Uh oh!
There was an error while loading. Please reload this page.