Fix map from microseconds to angle in renesas Servo::read#131
Open
martincwilliams wants to merge 1 commit intoarduino-libraries:masterfrom
Open
Fix map from microseconds to angle in renesas Servo::read#131martincwilliams wants to merge 1 commit intoarduino-libraries:masterfrom
martincwilliams wants to merge 1 commit intoarduino-libraries:masterfrom
Conversation
|
Memory usage change @ 009f3b9
Click for full report table
Click for full report CSV |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the renesas implementation,
Servo::read()reports a different value to what was previously set withServo::write().The value reported by
read()is 1 less than the value written usingwrite().In the
Servo::readfunction for renesas, the mapping from microseconds to angle is inconsistent with other implementations, such as avr, which add +1 to the microseconds value before mapping.Tested on a Uno Rev 4 Wifi => value returned by read was equal to value written for all angles from 0 to 180.