Fix mbed not using REFRESH_INTERVAL#132
Open
razvanphp wants to merge 1 commit intoarduino-libraries:masterfrom
Open
Fix mbed not using REFRESH_INTERVAL#132razvanphp wants to merge 1 commit intoarduino-libraries:masterfrom
razvanphp wants to merge 1 commit intoarduino-libraries:masterfrom
Conversation
Also do not use deprecated float as parameter, switch to chrono duration
|
Memory usage change @ fab0609
Click for full report table
Click for full report CSV |
This comment was marked as duplicate.
This comment was marked as duplicate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the Servo library for mbed-based boards to utilize std::chrono durations instead of manual conversions with floating-point numbers. The 20ms interval was hardcoded for mbed platform only.
Changes:
Benefits:
Testing:
Notes:
This change aligns the Servo library with the updated mbed OS API that favours
std::chronodurations since mbedOS 6.0.0, seehttps://github.com/arduino/ArduinoCore-mbed/blob/702daa02e244fb8710b48599f38786a67c590699/cores/arduino/mbed/drivers/include/drivers/Ticker.h#L85-L122