SAM Wire: fixed NACK/timeout behavior of requestFrom() and available() #1869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"readed" is no longer incremented in requestFrom() if TWI_WaitByteReceived() gets a NACK or times out. This corrects the behavior (return values) of requestFrom() and available() to match the Arduino reference. Fixes arduino#1311
cmaglie
added
Type: Bug
Library: Wire
facchinm
added a commit
that referenced
this pull request
Jul 1, 2015
SAM Wire: fixed NACK/timeout behavior of requestFrom() and available()
|
Merged, thank you! |
ollie1400
pushed a commit
to ollie1400/Arduino
that referenced
this pull request
May 2, 2022
SAM Wire: fixed NACK/timeout behavior of requestFrom() and available()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readedis no longer incremented inrequestFrom()ifTWI_WaitByteReceived()gets a NACK or times out. This corrects the behavior (return values) ofrequestFrom()andavailable()to match the Arduino reference; they should return the number of bytes actually available forread(), not the number of bytes requested, which was the previous behavior. Fixes #1311