[PUSB] Minor Style change #3948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the HID library adds some general HID definitions and structs, it is very useful to also include this in a custom library. If you dupe the information you have problems of redeclaration. Having those defintions inside the official HID library is essential for a good working additional HID API.
This was referenced Oct 10, 2015
| @@ -96,11 +96,16 @@ bool HID_::setup(USBSetup& setup) | |||
| // TODO: Send8(protocol); | |||
| return true; | |||
| } | |||
| if (request == HID_GET_IDLE) { | |||
| // TODO: Send8(idle); | |||
There was a problem hiding this comment.
Send8() cannot be accessed from here anyways. But its just a comment and the other requests above have the same syntax. I already mentioned that in the other PR, that should be fixed as well.
cmaglie
added
feature request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.