Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C33] Kvstore #428

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[C33] Kvstore #428

wants to merge 7 commits into from

Conversation

andreagilardoni
Copy link
Contributor

Importing KVStore from mbedos to be used with portenta c33

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Feb 5, 2025
@andreagilardoni andreagilardoni force-pushed the kvstore branch 2 times, most recently from 7a433c4 to 851253a Compare February 11, 2025 15:59
@andreagilardoni andreagilardoni marked this pull request as ready for review February 11, 2025 16:00
@andreagilardoni andreagilardoni mentioned this pull request Feb 11, 2025
Draft
pennam
pennam requested changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@pennam pennam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this code is intended to work on C33 only you need to add the .portenta_only file to avoid this folder to be included in the packaging of the UNO R4 core.

Is there a reason why there are no examples and library.properties files ?

@pennam
Copy link
Contributor

pennam commented Feb 13, 2025

I think adding an example in the core would be very useful for testing, either manual or for the "compile-example" workflow.

We should also consider changing the default partitioning sketch since this feature will be used by default in cloud sketches

@andreagilardoni andreagilardoni force-pushed the kvstore branch 2 times, most recently from bd977af to aed3c13 Compare February 18, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pennam pennam Awaiting requested review from pennam

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreagilardoni @pennam @per1234