Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

So i moved the libraries prperties to the hyperion since i made the f… #5873

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gi0rg0sPapamichail
Copy link
Contributor

So i moved the libraries prperties to the hyperion since i made the f…

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Hi @gi0rg0sPapamichail.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added the topic: modification Change existing list entry label Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Arduino Lint has suggestions for possible improvements to https://github.com/Hyperion-Robotics/YDLiDaR_GS2:

Linting library in YDLiDaR_GS2
INFO: No header file found matching library name (YDLidar.h). Best practices are for primary header filename to match   
      library name.                                                                                                     
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: Invalid category field value Sensor in library.properties                                             
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP038)                                                                                          
WARNING: Empty library.properties architectures field. Please define specific architectures or set to * if compatible   
         with all.                                                                                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP044)                                                                                                   

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Linting sketch in YDLiDaR_GS2/examples/ReadMeasurements

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 2 WARNINGS

@github-actions github-actions bot requested a review from per1234 February 5, 2025 17:57
The URL must be for the repository root. Previously, the URL was for a GitHub website subpage, and thus caused the validation check to fail:

> A problem was found with your submission https://github.com/Hyperion-Robotics/QuickESPNow/tree/main
>
> ❌ ERROR: Submission URL is not a Git clone URL (e.g., `https://github.com/arduino-libraries/Servo`).
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Arduino Lint has suggestions for possible improvements to https://github.com/Hyperion-Robotics/YDLiDaR_GS2:

Linting library in YDLiDaR_GS2
INFO: No header file found matching library name (YDLidar.h). Best practices are for primary header filename to match   
      library name.                                                                                                     
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: Invalid category field value Sensor in library.properties                                             
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP038)                                                                                          
WARNING: Empty library.properties architectures field. Please define specific architectures or set to * if compatible   
         with all.                                                                                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP044)                                                                                                   

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Linting sketch in YDLiDaR_GS2/examples/ReadMeasurements

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 2 WARNINGS

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @gi0rg0sPapamichail . I am confirming your request.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will merge this pull request when it is done. You will get a notification from GitHub at that time.

After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager

@arduino arduino deleted a comment from github-actions bot Feb 5, 2025
@per1234 per1234 added topic: URL change Change library repository URL status: pending backend Depends on backend maintenance operations and removed topic: modification Change existing list entry labels Feb 5, 2025
@arduino arduino deleted a comment from github-actions bot Feb 5, 2025
@arduino arduino deleted a comment from github-actions bot Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending backend Depends on backend maintenance operations topic: URL change Change library repository URL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants