fix: replace force-unwraps with guards in TextDecoder.decodeText#424
Open
yw5aj wants to merge 1 commit intoargmaxinc:mainfrom
Open
fix: replace force-unwraps with guards in TextDecoder.decodeText#424yw5aj wants to merge 1 commit intoargmaxinc:mainfrom
yw5aj wants to merge 1 commit intoargmaxinc:mainfrom
Conversation
Two force-unwraps in decodeText crash the app when decoder state degrades during sustained rapid transcription calls (e.g. live preview): - initialPrompt.last\! crashes when initialPrompt is empty - decoderOutput.logits\! crashes when logits is nil Replace with guard statements that throw descriptive errors, allowing callers to handle the failure gracefully instead of crashing. Fixes argmaxinc#414
Contributor
Author
|
No relation — we're an independent team that hit the same crash during live transcription. Glad to see others confirming the issue. Happy to defer to whichever PR you prefer to merge! |
Contributor
|
👍󠄳󠅜󠅟󠅣󠅕 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #414
Two force-unwraps in
decodeTextcrash the app when decoder state degrades during sustained rapid transcription calls (e.g., live transcription preview at ~5 calls/sec):decoderInputs.initialPrompt.last!— crashes wheninitialPromptis emptydecoderOutput.logits!— crashes when logits is nilThis PR replaces them with guard statements that throw descriptive errors, allowing callers to handle the failure gracefully instead of crashing the entire app.
Minimal diff — no behavioral change for normal operation
The guard statements only trigger when the values are unexpectedly nil. Normal transcription flow is unaffected.