Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly better error handling in L-BFGS #416

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

stefan-k
Copy link
Member

Related to #400

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (933508f) 90.40% compared to head (0ea3b60) 90.12%.

Files Patch % Lines
crates/argmin/src/solver/quasinewton/lbfgs.rs 46.66% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
- Coverage   90.40%   90.12%   -0.29%     
==========================================
  Files         162      162              
  Lines       20570    19549    -1021     
==========================================
- Hits        18597    17618     -979     
+ Misses       1973     1931      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefan-k stefan-k force-pushed the slightly_better_error_handling branch from 7804aa3 to e7a48c6 Compare January 25, 2024 07:35
@stefan-k stefan-k force-pushed the slightly_better_error_handling branch from e7a48c6 to 0ea3b60 Compare January 25, 2024 07:45
@stefan-k stefan-k merged commit e9bebb2 into argmin-rs:main Jan 25, 2024
18 checks passed
@stefan-k stefan-k deleted the slightly_better_error_handling branch January 25, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants