Skip to content

Conversation

@olivergondza
Copy link
Contributor

What type of PR is this?

/kind chore

What does this PR do / why we need it:

The examples in the docs are outdated

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

None

How to test changes / Special notes to the reviewer:

Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the kuttl tests, IMHO we can leave them as is and remove those changes from this PR. Why?

  • The kuttl tests will likely be entirely removed shortly, anyways.
  • The kuttl tests are no longer run as part of PRs, so this PR may unintentionally break them and we would not know. (Unless, for example, you have personally run those kuttl tests yourself from your own machine)

@olivergondza
Copy link
Contributor Author

For the kuttl tests, IMHO we can leave them as is and remove those changes from this PR. Why?

  • The kuttl tests will likely be entirely removed shortly, anyways.
  • The kuttl tests are no longer run as part of PRs, so this PR may unintentionally break them and we would not know. (Unless, for example, you have personally run those kuttl tests yourself from your own machine)

Yeah, makes sense since we want to throw them away. For my complete kuttl ignorance, it will that be all the references in tests/ of just the ones with kuttl CRs? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants