feat: Cache transform for Secrets and ConfigMaps to reduce memory #1866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
svghadi
changed the title
Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
anandf
reviewed
Sep 23, 2025
anandf
reviewed
Sep 23, 2025
anandf
reviewed
Sep 23, 2025
Signed-off-by: Anand Kumar Singh <[email protected]>
Signed-off-by: Anand Kumar Singh <[email protected]>
Signed-off-by: Anand Kumar Singh <[email protected]>
svghadi
commented
Oct 23, 2025
There was a problem hiding this comment.
Is it possible to add some tests for the wrapper?
cmd/main.go
Outdated
| if watchedNsCache := getDefaultWatchedNamespacesCacheOptions(); watchedNsCache != nil { | ||
| // Use transformers to strip data from Secrets and ConfigMaps | ||
| // that are not tracked by the operator to reduce memory usage. | ||
| if strings.ToLower(os.Getenv("MEMORY_OPTIMIZATION_ENABLED")) != "false" { |
There was a problem hiding this comment.
Lets use DISABLE_MEMORY_OPTIMIZATION env var which users should explicitly set to true to disable optimization
Signed-off-by: Anand Kumar Singh <[email protected]>
Signed-off-by: Anand Kumar Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
This PR reduces memory usage in the Argo CD Operator by introducing a cache transform and client wrapper for Secrets and ConfigMaps.
See the attached proposal in this PR for design details, trade-offs, PoC results, and future scope.
Results
These metrics were collected from a test cluster containing 100 ConfigMaps and 100 Secrets, each approximately 1 MB in size. The cluster was running four Argo CD instances and no other workload operators.
With the optimization enabled, operator memory usage dropped from ~350 MB to ~100 MB.
UnOptimized Operator Manager Memory:
Optimized Operator Manager Memory:
However, we could not reduce the startup memory consumption, which remained at ~750 MB in both cases.
We previously attempted another approach in #1795, but it introduced significant complexity and restricted how watches could be set up. Compared to that, this solution provides a better balance between complexity, maintenance overhead, and outcome.