Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add app metric for skip-reconcile feature #21626

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

baurmatt
Copy link

This people to build alerts for apps being to long in skip-reconcile state.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [-] Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

This allows to create alerts for apps that are too long in skip-reconcile state.

Signed-off-by: Matthias Baur <[email protected]>
Signed-off-by: Matthias Baur <[email protected]>
@baurmatt baurmatt requested review from a team as code owners January 22, 2025 13:49
Copy link

bunnyshell bot commented Jan 22, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.39%. Comparing base (5ef4faa) to head (81a85b9).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
controller/metrics/metrics.go 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21626   +/-   ##
=======================================
  Coverage   55.39%   55.39%           
=======================================
  Files         339      339           
  Lines       57176    57181    +5     
=======================================
+ Hits        31672    31678    +6     
+ Misses      22797    22794    -3     
- Partials     2707     2709    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant