-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Switch default logging to JSON (issue: 20897) #21656
base: master
Are you sure you want to change the base?
fix: Switch default logging to JSON (issue: 20897) #21656
Conversation
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
662dcf7
to
6c4f417
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21656 +/- ##
==========================================
+ Coverage 55.45% 55.59% +0.13%
==========================================
Files 339 340 +1
Lines 57196 57447 +251
==========================================
+ Hits 31718 31936 +218
- Misses 22812 22818 +6
- Partials 2666 2693 +27 ☔ View full report in Codecov by Sentry. |
Looks like you have to update the sources of the generated code and regenerate it with make. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just need to run the codegen.
Signed-off-by: Teddy Wahle <[email protected]>
6c4f417
to
2ac0f23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The e2e tests capture log output for validation of some commands, it looks like they will need to be updated to parse the json output.
Signed-off-by: Teddy Wahle <[email protected]>
ea57d38
to
c63d1e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for the PR!
Closes #20897
This change updates the default log format in
util/log
fromtext
tojson
. It will be used for ArgoCD v3.0.JSON logging is preferred because it produces structured logs, which are easier to parse and analyze with tools like Datadog and OpenTelemetry (Otel). These integrations rely on structured log formats to extract meaningful data and streamline observability workflows. Switching from
json
tojson
ensures better compatibility with modern logging and monitoring solutions.Checklist: