feat: improve StatefulSet immutable field error messages #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aali309
changed the title
14 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #654 +/- ##
==========================================
- Coverage 54.26% 53.82% -0.45%
==========================================
Files 64 64
Lines 6164 6551 +387
==========================================
+ Hits 3345 3526 +181
- Misses 2549 2738 +189
- Partials 270 287 +17 ☔ View full report in Codecov by Sentry. |
aali309
force-pushed
the
reportTheFieldThatViolated
branch
from
0ede6a9 to
ffd6fbb
Compare
aali309
force-pushed
the
reportTheFieldThatViolated
branch
3 times, most recently
from
ffd6fbb to
1751d55
Compare
|
feat: enhance StatefulSet immutable field error message to show specific field changes Signed-off-by: Atif Ali <[email protected]> formatting && added tests Signed-off-by: Atif Ali <[email protected]>
Signed-off-by: Atif Ali <[email protected]>
aali309
force-pushed
the
reportTheFieldThatViolated
branch
from
1751d55 to
8b51f31
Compare
Signed-off-by: Atif Ali <[email protected]>
Signed-off-by: Atif Ali <[email protected]>
Signed-off-by: Atif Ali <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: 20899
Depends on: 21209
Before:
After:
