chore: Use watch APIs to list k8s resources #716
Conversation
Signed-off-by: Andrii Korotkov <[email protected]>
Signed-off-by: Andrii Korotkov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #716 +/- ##
==========================================
- Coverage 54.26% 53.69% -0.57%
==========================================
Files 64 64
Lines 6164 6488 +324
==========================================
+ Hits 3345 3484 +139
- Misses 2549 2727 +178
- Partials 270 277 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Andrii Korotkov <[email protected]>
|
|
Is there some way this can be benchmarked? Like what are the expected performance improvements with this method (I imagine they are large, but ballpark numbers)? |
I'll try to think of something. |
| if opts.ResourceVersion == "" { | ||
| opts.ResourceVersion = "0" | ||
| } |
There was a problem hiding this comment.
Required by the list options construction function's code, otherwise it would return false as success.
| listResourcesUsingWatchAPI atomic.Int32 | ||
| listResourcesUsingRegularAPI atomic.Int32 |
There was a problem hiding this comment.
I think maybe we shouldn't do this, because listResources gets called a lot over the lifetime of a controller run (i.e. every time the cache expires or there's a retry due to an error). I don't think it's worth it just for the test. And maybe we can find a different way to test.
There was a problem hiding this comment.
Agree that it's not ideal, I'll think how to test better.
| t.Run(tc.name, func(t *testing.T) { | ||
| if tc.listUsingWatchAPIs { | ||
| // Enable WatchListClient in particular. Setting via env variable here is too late. | ||
| clientfeatures.ReplaceFeatureGates(AlwaysEnabledGates{}) |
There was a problem hiding this comment.
Looks like this enables every feature gate that can be enabled. Can we instead enable just the watch-list gate?
There was a problem hiding this comment.
It's a bit more complicated, and it's just for this test, so I'd rather keep this.
There was a problem hiding this comment.
Although shouldn't be too hard to construct gates more precisely.
Use watch APIs to list resources instead of paginated regular APIs.