Skip to content

fix: Server-Side diff removed fields missing in diff #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pjiang-dev
Copy link
Contributor

@pjiang-dev pjiang-dev commented May 16, 2025

fixes argoproj/argo-cd#23016 a bug that caused removed fields from predictedLive to be added back to predicted live resulting in removal of fields not showing in the diff

@pjiang-dev pjiang-dev requested a review from a team as a code owner May 16, 2025 15:59
Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 53.71%. Comparing base (8849c3f) to head (da81bd1).
Report is 45 commits behind head on master.

Files with missing lines Patch % Lines
pkg/diff/diff.go 78.57% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #722      +/-   ##
==========================================
- Coverage   54.26%   53.71%   -0.56%     
==========================================
  Files          64       64              
  Lines        6164     6486     +322     
==========================================
+ Hits         3345     3484     +139     
- Misses       2549     2728     +179     
- Partials      270      274       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server-Side diff does not show removal of fields
1 participant