Skip to content

Conversation

agaudreault
Copy link
Member

partial cherry-pick of #754 to mitigate argoproj/argo-cd#23226 on master.

This does not fix the codepaths that do not remove the finalizers, but allows new sync to work correctly to remediate the issue.

Signed-off-by: Alexandre Gaudreault <[email protected]>
@agaudreault agaudreault requested a review from a team as a code owner September 2, 2025 12:56
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

❌ Patch coverage is 62.16216% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.46%. Comparing base (8849c3f) to head (97e9173).
⚠️ Report is 58 commits behind head on master.

Files with missing lines Patch % Lines
pkg/sync/sync_context.go 62.16% 10 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #770      +/-   ##
==========================================
- Coverage   54.26%   47.46%   -6.80%     
==========================================
  Files          64       64              
  Lines        6164     6579     +415     
==========================================
- Hits         3345     3123     -222     
- Misses       2549     3199     +650     
+ Partials      270      257      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Alexandre Gaudreault <[email protected]>
Copy link

sonarqubecloud bot commented Sep 2, 2025

@agaudreault agaudreault merged commit dab4cc0 into argoproj:master Sep 2, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants