Collect instruction location info for EOF assembly #16052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clonker
force-pushed
the
eof_source_locations_unoptimized_assembly
branch
from
7a6d3fa to
a5e20d2
Compare
cameel
approved these changes
May 15, 2025
| for (auto const& [assemblyItemIndex, item]: codeSection.items | ranges::views::enumerate) | ||
| { | ||
| // collect instruction locations via side effects | ||
| InstructionLocationEmitter instructionLocationEmitter {instructionLocations, ret.bytecode, assemblyItemIndex}; |
Collaborator
There was a problem hiding this comment.
Suggested change
| InstructionLocationEmitter instructionLocationEmitter {instructionLocations, ret.bytecode, assemblyItemIndex}; | |
| InstructionLocationEmitter instructionLocationEmitter{instructionLocations, ret.bytecode, assemblyItemIndex}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #15994.