chore: Remove redundant post-loop invalidation in DataFlowAnalyzer::operator()(Switch& #16186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perator()(Switch&
cameel
requested changes
Aug 29, 2025
There was a problem hiding this comment.
The code does not even compile - have you properly verified your change? Note that CI is all red.
Also, while this would be a refactor, the correctness of DataFlowAnalyzer is pretty critical to Yul optimizer so we cannot take changes to it lightly. Please verify that in test/libyul/yulOptimizerTests/ the affected optimizer steps have adequate switch coverage. If not, we'll need extra tests before we can merge this.
|
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
bot
added
the
stale
cameel
added
external contribution ⭐
and removed
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete the extra clearKnowledgeIfInvalidated(_case.body) loop after processing all cases.
Per-case invalidation already applies the necessary clears, and joinKnowledge does not reintroduce knowledge, so the second pass is redundant.
Keeps behavior unchanged while reducing unnecessary work.