Disallow passing a empty array type to abi functions.
#16416
+48
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodiazet
requested review from
cameel and
nikola-matic
and removed request for
nikola-matic
|
There was an error when running Please check that your changes are working as intended. |
libsolidity/analysis/TypeChecker.cpp
Outdated
|
|
||
| #include <libsolidity/analysis/TypeChecker.h> | ||
|
|
||
| #include "DeclarationTypeChecker.h" |
rodiazet
force-pushed
the
zere_length_array
branch
from
aa31d42 to
12c9408
Compare
|
There was an error when running Please check that your changes are working as intended. |
libsolidity/analysis/TypeChecker.cpp
Outdated
|
|
||
| #include <libsolidity/analysis/TypeChecker.h> | ||
|
|
||
| #include "DeclarationTypeChecker.h" |
rodiazet
force-pushed
the
zere_length_array
branch
from
12c9408 to
bc948b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional check in
TypeCheckerforIndexAccesswhich ensures that the array size is not0.As a result of this change, type which is an empty array of contracts is also forbidden.
Fixes #13652.