chore: change lspecIO
#53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+83
to
+86
| def main := lspecIO $ .ofList [ | ||
| ("aa", aaSuite), | ||
| ("bb", bbSuite) | ||
| ] |
There was a problem hiding this comment.
To make usage abundantly clear, could we add a line of docs saying that you can then run the LSpec tests via lake test or lake test <a|aa> when including the following in lakefile.lean?
@[test_driver]
lean_exe Tests.Main
Even better would be a simple Lake project in Examples/ to show the intended directory structure.
* Repurpose `LSpec.lspecIO` as a CLI function that matches the arguments against test suite names * Sunset the old `lspec` and `lspec-ci` machinery, as `lake test` is in place with the `@[test_driver]` lakefile tag. * Remove unnecessary generic code that was never really used for other monads besides `IO`
arthurpaulino
force-pushed
the
ap/refactor-lspecIO
branch
from
6c2edf2 to
faeeafe
Compare
samuelburnham
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LSpec.lspecIOas a CLI function that matches the arguments against test suite nameslspecandlspec-cimachinery, aslake testis in place with the@[test_driver]lakefile tag.IO