added Vds prefix to Vue Components to avoid conflict with standard HTML elements #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
when using Vue Design System on a static website, there's a conflict between components which have the same name as a standard HTML element (i.e.
<Button>and<button>). This results in the standard HTML element being displayed instead of the Vue component.Solution:
renaming all Vue components by adding a prefix 'Vds', i.e. 'VdsButton' for a button component.
Extra:
in the examples (here and here) the component names should be changed as well. In the static website example, it would be best to use kebab-case for the components, i.e.
<vds-nav-bar>instead of<NavBar>and to add a recommendation for using kebab-case in the README.