Support vng O= in interactive mode
#229
Merged
+15
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When vng was used with O=my_dir/ to launch a VM, the VM stopped as soon
as the boot was done without any message, e.g.
host: $ vng O=.virtme/build
host: $
That's because O=my_dir/ was used as a command to execute in a
non-interactive mode: so simply setting an env var, and exiting.
Now, when O=... is passed, it is used to set the build dir where the
kernel image is, and this command is removed from the exec list. In
other words, this command will start a VM and start a prompt:
host: $ vng O=.virtme/build
vm: $
Fixes: afbec37 ("vng-run: get kdir from O=outdir")
Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
Before, only relative paths were allowed, I'm not sure why. Let's remove this restriction, simply by removing the './' prefix. Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
If this env var is set, and O= is not set, use this as the kernel build dir. Follow the same logic as in configkernel: only use it if set and pointing to a valid directory. While at it, also harmonise the code in configkernel around this env var. Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at the discussion #228, I noticed
vng O=my_dir/was not working as expected: with-v, I could see the VM booting, then stopping right after.That's because
virtme-runwas called with--script-sh "O=my_dir/" --kdir=./my_dir/, so simply setting an env var and exiting.Now
virtme-runwill be called with--kdir=my_dir/, so without--script-shand without the./prefix to allow full paths.