vng: support --nvgpu and --qemu-opts #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing arguments to virtme-run, --qemu-opts has to be the last one, because it will take all args set after that. In other words, --nvgpu was not supposed to be passed after --qemu-opts. While at it, re-order functions and add a comment to avoid re-doing the same mistake. Note that an alternative would be to call virtme-run with --qemu-opt instead of --qemu-opts (with 's'). But a comment should be enough. Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
arighi
approved these changes
Feb 7, 2025
| + f'{self.virtme_param["qemu"]} ' | ||
| + f'{self.virtme_param["qemu_opts"]} ' | ||
| + f'{self.virtme_param["nvgpu"]} ' | ||
| # Important: qemu_opts has to be the last one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing arguments to
virtme-run,--qemu-optshas to be the last one, because it will take all args set after that.In other words,
--nvgpuwas not supposed to be passed after--qemu-opts.While at it, re-order functions and add a comment to avoid re-doing the same mistake.
Note that an alternative would be to call
virtme-runwith--qemu-optinstead of--qemu-opts(with 's'). But a comment should be enough.