Skip to content

Use typeOf as key instead of KClass in InstanceKeeper#getStore #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,15 @@ package com.arkivanov.mvikotlin.core.instancekeeper
import com.arkivanov.essenty.instancekeeper.InstanceKeeper
import com.arkivanov.essenty.instancekeeper.getOrCreate
import com.arkivanov.mvikotlin.core.store.Store
import kotlin.reflect.typeOf

fun <T : Store<*, *, *>> InstanceKeeper.getStore(key: Any, factory: () -> T): T =
getOrCreate(key = key) {
StoreInstance(factory())
}.store

inline fun <reified T : Store<*, *, *>> InstanceKeeper.getStore(noinline factory: () -> T): T =
getStore(key = T::class, factory = factory)
getStore(key = typeOf<T>(), factory = factory)

private class StoreInstance<out T : Store<*, *, *>>(
val store: T
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
package com.arkivanov.mvikotlin.core.instancekeeper

import com.arkivanov.essenty.instancekeeper.InstanceKeeperDispatcher
import com.arkivanov.mvikotlin.core.rx.Disposable
import com.arkivanov.mvikotlin.core.rx.Observer
import com.arkivanov.mvikotlin.core.store.Store
import kotlin.test.Test
import kotlin.test.assertNotSame
import kotlin.test.assertSame

@Suppress("TestFunctionName")
class InstanceKeeperExtTest {

private val keeper = InstanceKeeperDispatcher()

@Test
fun WHEN_getStore_with_same_type_THEN_same_instance() {
val store1 = keeper.getStore { store<String, Float, Int>() }
val store2 = keeper.getStore { store<String, Float, Int>() }

assertSame(store1, store2)
}

@Test
fun WHEN_getStore_with_different_types_THEN_instances_not_same() {
val store1 = keeper.getStore { store<Int, String, Float>() }
val store2 = keeper.getStore { store<String, Float, Int>() }

assertNotSame<Store<*, *, *>>(store1, store2)
}

private fun <Intent : Any, State : Any, Label : Any> store(): Store<Intent, State, Label> =
object : Store<Intent, State, Label> {
override val state: State get() = error("Not implemented")
override val isDisposed: Boolean get() = error("Not implemented")

override fun states(observer: Observer<State>): Disposable =
error("Not implemented")

override fun labels(observer: Observer<Label>): Disposable =
error("Not implemented")

override fun accept(intent: Intent) {
error("Not implemented")
}

override fun init() {
error("Not implemented")
}

override fun dispose() {
error("Not implemented")
}
}
}