Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: trim branch from center #116

Merged
merged 2 commits into from
Jun 9, 2024
Merged

Conversation

rtalexk
Copy link
Contributor

@rtalexk rtalexk commented Jun 9, 2024

Purpose

I tend to follow a naming convention for branches, and when I work on big features that are split into different PRs, the beginning and the end of the branches contains the most significant context, i.e: feat/<ticket_id>/<feature-name>-<feature-portion>. In these cases I find useful seeing the beginning of the branch, and as I already know which feature I'm working on, I find more value by seeing the last part, as it usually refers to a smaller portion of the whole feature.

Hopefully others also finds this useful.

Approach

Trim the branch from the inside out, so that

feat/COR-1032/supplier-billing-profile-invoice-upload

becomes

feat/COR-1032/…invoice-upload

@rtalexk rtalexk force-pushed the feat/trim-branch-from-center branch from 551d1d8 to a882b42 Compare June 9, 2024 00:39
Copy link
Owner

@arl arl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing that, very helpful.

Can you please update the documentation in .gitmux.yml at project root? This file gets embedded in the binary at build time and serves as default config for gitmux -printcfg?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the complete test cases

@rtalexk rtalexk force-pushed the feat/trim-branch-from-center branch 2 times, most recently from 02a8952 to cc84284 Compare June 9, 2024 02:35
@rtalexk rtalexk force-pushed the feat/trim-branch-from-center branch from cc84284 to 45568dc Compare June 9, 2024 02:37
Copy link
Owner

@arl arl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arl arl merged commit bb31d30 into arl:main Jun 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants