Skip to content

feat: Rewrite crd2jsonschema in Go#78

Closed
kalbasit wants to merge 1 commit into
arnarg:mainfrom
kalbasit:crd2jsonschema
Closed

feat: Rewrite crd2jsonschema in Go#78
kalbasit wants to merge 1 commit into
arnarg:mainfrom
kalbasit:crd2jsonschema

Conversation

@kalbasit

@kalbasit kalbasit commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

This is probably not the best fix for #76 but Go is more stable anyways. The code is generated by Gemini by giving it the Python version (and the test file). I didn't spend time going over the code manually because I wanted to first know if you're open to taking this code; At that point I can spend time ensuring the code meets my Go standards. I will also update the Github workflow.

fixes #76

@arnarg

arnarg commented Dec 10, 2025

Copy link
Copy Markdown
Owner

While I definitely prefer programming in Go over python, I went with python originally as I do not want to have a compilation step for the user or a requirement for a binary cache. Fetching a few dependencies for a python environment from the standard NixOS binary cache is fairly quick.

Thanks for the contribution though! I want to rather workaround the issue in #76 by removing the loader that is causing trouble in pyyaml.

@arnarg arnarg closed this Dec 10, 2025
@kalbasit

Copy link
Copy Markdown
Contributor Author

That's a fair view although one could argue that it can be made its own project and moved to nixpkgs to avoid building it 😄 Either way, I'm fine either way as long as it works.

@kalbasit
kalbasit deleted the crd2jsonschema branch December 10, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fromChartCRD is broken for kube-prometheus-stack

2 participants