Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds netstandard2.0 and net10.0 as additional target frameworks to the main library project and migrates the solution to use Central Package Management (CPM) via Directory.Packages.props. The change also includes several package version updates that were not mentioned in the PR description.
Key changes:
- Added netstandard2.0 and net10.0 to target frameworks for the main library
- Migrated all projects to Central Package Management with Directory.Packages.props
- Updated multiple package versions (NLog, RabbitMQ.Client, Newtonsoft.Json, and test dependencies)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Nlog.RabbitMQ.Target/Nlog.RabbitMQ.Target.csproj | Added netstandard2.0 and net10.0 target frameworks; removed version attributes from package references; added LangVersion 10 for netstandard2.0 |
| Directory.Packages.props | New file implementing Central Package Management with centralized package version definitions |
| tests/Nlog.RabbitMQ.Target.Tests/Nlog.RabbitMQ.Target.Tests.csproj | Removed version attributes from package references to use CPM |
| src/Nlog.RabbitMQ.WebSample/Nlog.RabbitMQ.WebSample.csproj | Removed version attributes from package references to use CPM |
| src/Nlog.RabbitMQ.Sample/Nlog.RabbitMQ.Sample.csproj | Removed version attributes from package references to use CPM |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
artdolya
force-pushed
the
Add-Netstandard20-and-10
branch
from
1828a62 to
ac572a4
Compare
Contributor
|
Since you are targeting rabbitmq.client that only supports NetStandard2 and NET8, then maybe remove NET6 + NET9 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.