Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#23382 feat(*): run rector over source #3

Merged
merged 19 commits into from
Jan 27, 2025
Merged

#23382 feat(*): run rector over source #3

merged 19 commits into from
Jan 27, 2025

Conversation

tmArtemeon
Copy link
Contributor

@tmArtemeon tmArtemeon commented Jan 23, 2025 •
edited by marcreichel
Loading

📝 Description

  • Changes for PHP 8.4 compatibility
  • Unit Tests with 100% code coverage (including mutation tests)
  • Streamlined code style
  • PHPStan Level 10

@tmArtemeon tmArtemeon self-assigned this Jan 23, 2025
micharoesler
micharoesler previously approved these changes Jan 23, 2025
View reviewed changes
@tmArtemeon tmArtemeon changed the base branch from main to 1.x January 24, 2025 09:26
@marcreichel marcreichel self-assigned this Jan 24, 2025
@marcreichel marcreichel removed their request for review January 24, 2025 20:11
micharoesler
micharoesler previously approved these changes Jan 27, 2025
View reviewed changes
@marcreichel marcreichel marked this pull request as ready for review January 27, 2025 11:10
@marcreichel marcreichel enabled auto-merge January 27, 2025 11:12
@marcreichel marcreichel merged commit a211978 into 1.x Jan 27, 2025
4 checks passed
@marcreichel marcreichel deleted the feat/#23382-rector branch February 8, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidler sidler sidler approved these changes

@micharoesler micharoesler micharoesler approved these changes

@chriskapp chriskapp Awaiting requested review from chriskapp

Assignees

@marcreichel marcreichel

@tmArtemeon tmArtemeon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tmArtemeon @sidler @micharoesler @marcreichel