1.2.4 – Navigation Enhancements (vibe-kanban) #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a responsive navigation menu with a mobile toggle, focus trap, and ESC-to-close functionality. The header is transparent on the front page and becomes solid on scroll or on other pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{
"task_id": "1.2.4",
"task_title": "Navigation Enhancements (classic PHP)",
"objective": "Finalize navigation with full menu entries and improve accessibility and mobile behavior.",
"requirements": [
"Ensure primary menu includes Home, Work (Projects archive), About, and Contact in that order.",
"Add logic to highlight the current page (active state).",
"Implement mobile menu toggle with accessible focus trap and ESC-to-close behavior.",
"Ensure header background: transparent overlay on front page hero, solid background on all other pages."
],
"acceptance_criteria": [
"Nav displays correct entries: Home, Work, About, Contact.",
"Active page is highlighted in the menu.",
"Mobile menu opens/closes smoothly, traps focus, and closes on ESC key.",
"Header background overlays hero video on front page; is solid elsewhere.",
"No regressions to layout or console errors."
],
"file_scope": [
"header.php",
"functions.php",
"style.css",
"script.js (or inline JS if no dedicated file yet)"
],
"post_task_actions": [
"Update README changelog with 1.2.4 details.",
"Push branch and open PR: '1.2.4 Navigation Enhancements'"
]
}