Conversation
OkHttp's body-level interceptor dumps every request and response payload to Logcat regardless of build variant. While THabella only serves public room schedules, logging all traffic in production wastes CPU and battery and sets a bad precedent for future work. Gated on BuildConfig.DEBUG. Also enabled the buildConfig AGP feature so the constant is actually generated.
Centralise date-format patterns into AppDateFormats (data layer) and UiDateFormats (UI layer), eliminating 7 duplicate formatter declarations across PeriodMapper, LocalMappers, RoomRepositoryImpl, HomeScreen, RoomDetailScreen, RoomListScreen, and ScheduleCard. Extract the German umlaut normalisation pipeline into a shared String.normalizeForMatching() extension (GermanStringNormalization.kt) so RoomPriorityPolicy and RoomPresentationFormatter share one implementation. Move the six taxonomy @serializable models out of the 600-line formatter into RoomTaxonomy.kt. Add isMainCampus flags to 9 taxonomy buildings and a JSON Schema for the taxonomy file. Two bidirectional tests guard the policy's hardcoded building set against the taxonomy. iOS RoomRepository cache TTLs extracted to named constants. New tests: RoomRepositoryImpl cache and fallback paths (9 cases), date-parsing boundary and error inputs (5 cases), auto-refresh loop fires and cancels for Home and RoomList ViewModels, iOS HomeViewModel suite (5 cases). CI parameterises Java version and simulator name into env vars and wraps all build/test steps with retry logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopens the dev branch after the reset and includes fixes for the iOS compile failures that broke the Appetize preview on the previous merge attempt.\n\nValidation so far:\n- Android local: assembleDebug test lint\n- Appetize workflow on dev: Android Preview and iOS Preview passed