Skip to content

adds sha1 hash to json#42

Open
hruljov wants to merge 1 commit intoaruhier:devfrom
hruljov:master
Open

adds sha1 hash to json#42
hruljov wants to merge 1 commit intoaruhier:devfrom
hruljov:master

Conversation

@hruljov
Copy link
Copy Markdown

@hruljov hruljov commented Mar 23, 2021

No description provided.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.8%) to 82.633% when pulling e1426fb on hruljov:master into bbcf560 on aruhier:dev.

@aruhier
Copy link
Copy Markdown
Owner

aruhier commented Mar 23, 2021

Hi,
Thanks a lot for your PR!

However I have an issue with the fact that each image disk will be read twice. I'm wondering if it would not be better to compute the hash in the packagers, when adding a file. The packagers could return a hash as a result.

@hruljov
Copy link
Copy Markdown
Author

hruljov commented Mar 24, 2021

Need to look at the functional packagers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants