Add support for larger Twitter profile images #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,6 +71,8 @@ def image_url | |||
| original_url.sub('normal', 'bigger') | |||
| when 'original' | |||
| original_url.sub('_normal', '') | |||
| when '400x400' | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| @@ -71,6 +71,8 @@ def image_url | |||
| original_url.sub('normal', 'bigger') | |||
| when 'original' | |||
| original_url.sub('_normal', '') | |||
| when '400x400' | |||
| original_url.sub('normal', '400x400') | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
I don't see that 400x400 size specified anywhere. Also, the code |
|
I fixed the PR. It doesn't look like 400x400 is documented in API v1.1. Maybe it'll come soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twitter has recently added support for 400x400 thumbnails coinciding with their re-design. This PR adds support for that.