Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported :image_size as Symbol in authentication options #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pramodshinde
Copy link

Allowed :image_size as Symbol in authentication options

@cllns
Copy link
Contributor

cllns commented May 2, 2018

👍 Just ran into this issue where I specified the image_size as a symbol and it didn't work.

I think:

 image_size = options[:image_size].is_a?(String) ? options[:image_size] : options[:image_size].to_s

could be simplified to:

image_size = options[:image_size].to_s

Since a String#to_s returns itself :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants