Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

capturing metadata from LLMs #1122

Merged
merged 10 commits into from
Jan 28, 2025
Merged

capturing metadata from LLMs #1122

merged 10 commits into from
Jan 28, 2025

Conversation

Soeb-aryn
Copy link
Contributor

@Soeb-aryn Soeb-aryn commented Jan 23, 2025 •
edited
Loading

Adding LLM request metrics, such as wall_latency, in_token, and out_token, to the docset metadata for each LLM call.

baitsguy
baitsguy reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@baitsguy baitsguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we're repeating the same code a bunch of times, can you consolidate.

Also please add tests

@Soeb-aryn Soeb-aryn marked this pull request as ready for review January 27, 2025 19:05
baitsguy
baitsguy approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@baitsguy baitsguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you add an assertion to an existing integ test too

@Soeb-aryn Soeb-aryn merged commit 088f4b6 into main Jan 28, 2025
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baitsguy baitsguy baitsguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Soeb-aryn @baitsguy