fix!: Be aware of ForcePrepend#2028
Conversation
32bab49 to
137b35f
Compare
Previously, the value of `ForcePrepend` was not used anywhere and was not behaving as specified. With this commit, the behavior will be as specified. BREAKING CHANGE: So far, `ASDF_FORCE_PREPEND` environment variable setting has been ignored, but this commit may change the behavior depending on the setting. If it is not set, macOS behavior will not change, but Linux behavior will change. If you want to get the same behavior as before, it is recommended to set the relevant environment variable. Referenced Documents: - https://github.com/asdf-vm/asdf/blob/932ac468b7c24c2adef90a293a1f7280a0074cc4/docs/manage/configuration.md#asdf_force_prepend Background: @andrecloutier told about this issue me in a comment on another PullRequest. Thank you! - asdf-vm#2011 (comment)
5e0609e to
f9bf8fb
Compare
ForcePrependForcePrepend
|
Hi @machupicchubeta , thanks for this PR and your previous one. I should have given more thought before merging #2011 and #2026. The force prepend option was only ever used one place - https://github.com/asdf-vm/asdf/blob/master/asdf.sh#L63. This file was a Bash script used in version 0.15.0 and older. It was sourced by the shell to expose an The force prepend option was never actually used in the internal code for asdf, even in the older versions. It was only ever used for altering the |
|
Closing for now in favor of #2089 |
|
@Stratus3D |
Summary
Previously, the value of
ForcePrependwas not used anywhere and was not behaving as specified.With this commit, the behavior will be as specified.
BREAKING CHANGE
So far,
ASDF_FORCE_PREPENDenvironment variable setting has been ignored, but this commit may change the behavior depending on the setting.If it is not set, macOS behavior will not change, but Linux behavior will change.
If you want to get the same behavior as before, it is recommended to set the relevant environment variable.
Other Information
Referenced Documents
Background
@andrecloutier told about this issue me in a comment on another PullRequest. Thank you!
ASDF_FORCE_PREPENDenvironment variable #2011 (comment)