-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to Bazel 8 #390
Merged
+312
−548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for using this repo in Bazel training courses with symbolic macros
|
a51bcf3
to
2d4b540
Compare
gregmagolan
reviewed
Jan 12, 2025
@@ -64,6 +65,7 @@ http_jar( | |||
# Fetch tools | |||
# https://blog.aspect.build/run-tools-installed-by-bazel | |||
multitool = use_extension("@rules_multitool//multitool:extension.bzl", "multitool") | |||
multitool.hub(lockfile = "//.aspect/workflows:deps.lock.json") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎
gregmagolan
approved these changes
Jan 12, 2025
alexeagle
added a commit
that referenced
this pull request
Jan 13, 2025
It was removed in #390 but that broke 'bazel configure'. Also upgrade Aspect CLI to latest while I'm here, though it didn't fix anything
alexeagle
added a commit
that referenced
this pull request
Jan 13, 2025
It was removed in #390 but that broke 'bazel configure'. Also upgrade Aspect CLI to latest while I'm here, though it didn't fix anything
alexeagle
added a commit
that referenced
this pull request
Jan 13, 2025
It was removed in #390 but that broke 'bazel configure'. Also upgrade Aspect CLI to latest while I'm here, though it didn't fix anything
alexeagle
added a commit
that referenced
this pull request
Jan 14, 2025
It was removed in #390 but that broke 'bazel configure'. Also upgrade Aspect CLI to latest while I'm here, though it didn't fix anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for using this repo in Bazel training courses with symbolic macros