Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to Bazel 8 #390

Merged
merged 8 commits into from
Jan 12, 2025
Merged

chore: upgrade to Bazel 8 #390

merged 8 commits into from
Jan 12, 2025

Conversation

alexeagle
Copy link
Member

Needed for using this repo in Bazel training courses with symbolic macros

Needed for using this repo in Bazel training courses with symbolic macros
Copy link
Contributor

aspect-workflows bot commented Jan 11, 2025

Test

5 test targets passed

Targets
//.aspect/bazelrc:update_aspect_bazelrc_presets_4_test [k8-fastbuild]        215ms
//.aspect/bazelrc:update_aspect_bazelrc_presets_5_test [k8-fastbuild]        103ms
//.aspect/bazelrc:update_aspect_bazelrc_presets_6_test [k8-fastbuild]        91ms
//logger/client/src/build/aspect:JavaLoggingClientLibraryTest [k8-fastbuild] 1s
//logger/client/src/build/aspect:JavaLoggingClientTest [k8-fastbuild]        387ms

Total test execution time was 2s. 22 tests (81.5%) were fully cached saving 13s.


Format      Lint

@alexeagle alexeagle force-pushed the bazel8 branch 2 times, most recently from a51bcf3 to 2d4b540 Compare January 12, 2025 00:11
@alexeagle alexeagle requested a review from gregmagolan January 12, 2025 00:35
@alexeagle alexeagle marked this pull request as ready for review January 12, 2025 00:43
@@ -64,6 +65,7 @@ http_jar(
# Fetch tools
# https://blog.aspect.build/run-tools-installed-by-bazel
multitool = use_extension("@rules_multitool//multitool:extension.bzl", "multitool")
multitool.hub(lockfile = "//.aspect/workflows:deps.lock.json")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@alexeagle alexeagle merged commit 0aa3751 into main Jan 12, 2025
13 of 14 checks passed
@alexeagle alexeagle deleted the bazel8 branch January 12, 2025 17:20
alexeagle added a commit that referenced this pull request Jan 13, 2025
It was removed in #390 but that broke 'bazel configure'.
Also upgrade Aspect CLI to latest while I'm here, though it didn't fix anything
alexeagle added a commit that referenced this pull request Jan 13, 2025
It was removed in #390 but that broke 'bazel configure'.
Also upgrade Aspect CLI to latest while I'm here, though it didn't fix anything
alexeagle added a commit that referenced this pull request Jan 13, 2025
It was removed in #390 but that broke 'bazel configure'.
Also upgrade Aspect CLI to latest while I'm here, though it didn't fix anything
alexeagle added a commit that referenced this pull request Jan 14, 2025
It was removed in #390 but that broke 'bazel configure'.
Also upgrade Aspect CLI to latest while I'm here, though it didn't fix anything
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants