Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mirror commits from bazel-examples to downstreams #394

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Conversation

alexeagle
Copy link
Member

@alexeagle alexeagle commented Jan 14, 2025

Note, I put deploy public keys into each of the downstream repos, the private keys are stored in GHA secrets in this repo.

NB: this assumes that the push is a fast-forward, meaning we prevent commits to those two downstream repos directly. If it's not a fast-forward, this new GHA workflow will fail on the git push step.

@gregmagolan are you okay with making any GHA or CCI edits to this repo and then letting the automation push them? If not I'll have to do something fancier here to rewrite commits on top of the history of the target repo, essentially a rebase.


Changes are visible to end-users: no

Test plan

Will run the new workflow manually at first.

@alexeagle alexeagle requested a review from gregmagolan January 14, 2025 01:15
Copy link
Contributor

aspect-workflows bot commented Jan 14, 2025

Test

All tests were cache hits

27 tests (100.0%) were fully cached saving 15s.


Format      Lint      Lint [.]

@gregmagolan
Copy link
Member

@gregmagolan are you okay with making any GHA or CCI edits to this repo and then letting the automation push them? If not I'll have to do something fancier here to rewrite commits on top of the history of the target repo, essentially a rebase.

Yes, this is fine and is the workflow I was expecting. Edits that affect Workflows in the downstream repos can be tested manually on branches in the downstream repos and then once tested put up in a PR to this repo.

Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@alexeagle alexeagle enabled auto-merge (squash) January 14, 2025 04:16
@alexeagle alexeagle merged commit 3a12238 into main Jan 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants